Implement limit on max-concurrency. #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2032 +/- ##
==========================================
- Coverage 71.54% 71.45% -0.09%
==========================================
Files 98 99 +1
Lines 10756 10805 +49
==========================================
+ Hits 7695 7721 +26
- Misses 2718 2736 +18
- Partials 343 348 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sethiay
reviewed
Jun 19, 2024
internal/cache/file/downloader/job_manager_parallel_downloads_test.go
Outdated
Show resolved
Hide resolved
internal/cache/file/downloader/job_manager_parallel_downloads_test.go
Outdated
Show resolved
Hide resolved
internal/cache/file/downloader/job_manager_parallel_downloads_test.go
Outdated
Show resolved
Hide resolved
internal/cache/file/downloader/job_manager_parallel_downloads_test.go
Outdated
Show resolved
Hide resolved
sethiay
reviewed
Jun 20, 2024
sethiay
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Limit max-concurrency of parallel downloads across jobs using a semaphore.
Link to the issue in case of a bug fix.
NA
Testing details